CyclesOptions : Remove samplingPattern
#5726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a debug-level field in Blender, so it's more appropriate to hide it while allowing a power user to specify it via CustomOptions. Moreover, the presets values we had were out of date and completely non-functional.
I've also verified that Cycles' standalone default of
SAMPLING_PATTERN_TABULATED_SOBOL
matches Blenders's UI default, so when Gaffer doesn't specify anything, we are getting the intended sampling pattern.